fix(generator): sanitize identifiers and extract last path segment #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the identifier sanitization logic to handle backslashes, replace them with forward slashes, split paths, and extract the last segment. This ensures consistent identifier naming and improves compatibility with cross-platform path formats.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the identifier sanitization logic in the source generator that creates project interfaces from solution files. The change adds path normalization (replacing backslashes with forward slashes), path splitting, and extraction of the last path segment to generate valid C# identifiers from project names.
Key changes:
- Adds backslash-to-forward-slash conversion for project keys before identifier generation
- Implements path splitting and last-segment extraction to handle potential path separators in project names
- Maintains existing dot and space replacement for identifier sanitization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the identifier sanitization logic to handle backslashes, replace them with forward slashes, split paths, and extract the last segment. This ensures consistent identifier naming and improves compatibility with cross-platform path formats.