feat: add realtime resolution support#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets realtime SDK users request 720p or 1080p streams at connect time while keeping existing behavior unchanged when no resolution is provided.
It also aligns realtime model FPS metadata with the current 30 FPS streaming experience so application UI and telemetry can reflect the realtime product correctly.
Validated with
uv run pytestanduv run ruff check decart tests/test_models.py tests/test_realtime_unit.py.Note
Medium Risk
Adds a new connect-time query parameter for realtime streams and changes advertised realtime FPS values to 30, which may affect client expectations and downstream UI/telemetry that relies on these fields.
Overview
Adds optional realtime resolution selection by extending
RealtimeConnectOptionswithresolution(720p/1080p) and appending it to the WebRTC connect URL when provided.Updates realtime model registry metadata to advertise 30 FPS across lucy/mirage realtime models (tests adjusted accordingly), and bumps the package version to
0.0.38with new unit tests verifying resolution URL behavior.Reviewed by Cursor Bugbot for commit cd93fda. Bugbot is set up for automated code reviews on this repo. Configure here.