fix(examples): address PR #105 review comments#106
Merged
AdirAmsalem merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
Increase express.json body limit to 50mb for base64 data URL payloads, remove duplicate example files left over from deprecated model removal, and update README references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses open review comments from #105 (deprecated model removal):
express.json()body size limit to 50mb so base64 data URL payloads don't hit the default 100KB captext-to-image.ts,text-to-video.ts,image-to-video.ts) that were repurposed during model removal but became identical to existing examples with misleading namesexamples/sdk-core/README.mdreferences accordinglyTest plan
🤖 Generated with Claude Code
Note
Low Risk
Low risk: changes are confined to example code and documentation, mainly increasing request body size and deleting redundant example scripts.
Overview
Updates the
examples/express-apiserver to accept large base64 payloads by raising theexpress.json()body limit to50mb.Cleans up
examples/sdk-coreby removing three redundant/misleading example scripts (image/text-to-image.ts,video/text-to-video.ts,video/image-to-video.ts) and updating the README to point to the remainingimage-to-imageandvideo-to-videoexamples.Written by Cursor Bugbot for commit 993cd92. This will update automatically on new commits. Configure here.