Revert "feat: add TURN-TCP support with server-driven config (#112)"#115
Merged
nagar-decart merged 1 commit intomainfrom Apr 7, 2026
Merged
Revert "feat: add TURN-TCP support with server-driven config (#112)"#115nagar-decart merged 1 commit intomainfrom
nagar-decart merged 1 commit intomainfrom
Conversation
This reverts commit 39b9f09.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #112. Merged by mistake — the SDK PR needs to land together with the API PR (DecartAI/api#971).
Note
Medium Risk
Changes the realtime/WebRTC connection setup by removing TURN server configuration and related signaling handling, which can affect connectivity in restricted NAT/firewall environments. Also deletes associated E2E coverage, increasing the chance of regressions going unnoticed.
Overview
Reverts the previously added TURN-TCP support in the realtime SDK by removing
iceServers/iceTransportPolicyconnect options and dropping theturn_configsignaling message path.WebRTC peer connections now always use a fixed STUN-only
iceServerslist, and the websocket URL no longer includes theice_transport_policyquery param. The TURN-TCP E2E test/config and thetest:e2e:turn-tcpscript are removed.Reviewed by Cursor Bugbot for commit 5f31ec2. Bugbot is set up for automated code reviews on this repo. Configure here.