Skip to content

fix: lucy-2 realtime video dimensions#120

Merged
AdirAmsalem merged 2 commits intomainfrom
bugfix/lucy-2-dimensions
Apr 19, 2026
Merged

fix: lucy-2 realtime video dimensions#120
AdirAmsalem merged 2 commits intomainfrom
bugfix/lucy-2-dimensions

Conversation

@roekatz
Copy link
Copy Markdown
Contributor

@roekatz roekatz commented Apr 19, 2026

Should be 624x1088 instead of 720x1280


Note

Low Risk
Low risk: only updates realtime model metadata (width/height) and adjusts unit tests accordingly, with no changes to request flow or validation logic.

Overview
Fixes the lucy-2 realtime model definitions (lucy-2 and deprecated lucy_2_rt) to report dimensions as 1088x624 instead of 1280x720.

Updates unit tests to assert the new realtime dimensions for both the canonical and deprecated model names.

Reviewed by Cursor Bugbot for commit dd544ba. Bugbot is set up for automated code reviews on this repo. Configure here.

Should be 624x1088 instead of 720x1280
@roekatz roekatz requested a review from AdirAmsalem April 19, 2026 15:08
@AdirAmsalem AdirAmsalem changed the title Fix lucy-2 realtime video dimensions fix: lucy-2 realtime video dimensions Apr 19, 2026
@AdirAmsalem AdirAmsalem merged commit e8a7836 into main Apr 19, 2026
4 checks passed
@AdirAmsalem AdirAmsalem deleted the bugfix/lucy-2-dimensions branch April 19, 2026 18:12
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit dd544ba. Configure here.

width: 1280,
height: 720,
width: 1088,
height: 624,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Video model lucy-2 dimensions not updated to match

High Severity

The _models.video["lucy-2"] and _models.video["lucy-2-v2v"] entries still have the old dimensions (width: 1280, height: 720), while the realtime counterparts were updated to 1088x624. The lucy-2.1 model has consistent dimensions (1088x624) across both realtime and video sections, suggesting lucy-2 video entries were missed in this fix.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit dd544ba. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants