Skip to content

fix: Restrict the several countries execution to night cycles.#154

Merged
dktsni merged 1 commit intoversion/4.1.0from
fix/5/update_deleted_comments_on_functionalities
Sep 11, 2019
Merged

fix: Restrict the several countries execution to night cycles.#154
dktsni merged 1 commit intoversion/4.1.0from
fix/5/update_deleted_comments_on_functionalities

Conversation

@dktsni
Copy link
Copy Markdown
Contributor

@dktsni dktsni commented Sep 11, 2019

Type of modification

  • Breaking change
  • New Feature
  • Bug Fix
  • Chore (refactor, documentation, tests... all the changes with no impact on ARA functionalities.)

Changes description

Fix #5
Update the Functionalities -> Cartography screen to refresh the non mandatory text fields when they're updated and removed.

Technical description

Fill the comment and created attributes in the FunctionalityDTO with empty strings when their values are null after the DB update to force them to appear in the response's body.

  • Some minor clean up (useless (un)boxing + check nullity in responses' body in the FunctionalityResourceIT test class).

PR CheckList

Please make sure your PullRequest respect all those items :

  • Your PR's title has the prefix : feat:, fix: or chore:
  • Unless your PR is related to a Hotfix (and approved by a ARA maintener), the targeted branch for it is the branch version/X.Y.Z and not master
  • You have asked a review from one of the ARA maintainer in your PR.
  • If your PR is related to an issue, add the issue's number in it.
  • All the code you added is documented.
  • All the code you added is tested and the tests are in success.
  • You already signed the Contributor License Agreement and give us the document

@dktsni dktsni merged commit 0759e7c into version/4.1.0 Sep 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix/5/update_deleted_comments_on_functionalities branch September 11, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to delete comments on functionalities part

1 participant