Marking attendance using s/all in mark command

[Decaxical]

UG states that "mark c/1 w/3 s/all marks the attendances of all the students belonging to the 1st class
group for week 3."

However when running the mark command using s/all

Instead TAssist attempts to mark ALL students even those not existing in the class group specified

[nus-pe-script]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unmarking students using s/all in unmark command

UG states that "unmark c/1 w/3 s/all unmarks the attendances of all the students belonging to the 1st
class group for week 3"

However when using s/all,

TAssist attempts to unmark ALL students even those that are not part of the group

---

_{[original: nus-cs2103-AY2122S2/pe-interim#2492] [original labels: type.FunctionalityBug severity.Medium]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The command works as intended in marking/unmarking the attendances of all the students belonging to the 1st class group for week 3. Also, it is stated that when all parameter is used, we will include all students. The following line is lifted from our UG under unmark attendance: Students may be specified with either all (i.e. all students), STUDENT_INDEXES or STUDENT_IDS.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• I disagree

Reason for disagreement: Only disagreeing that this is a duplicate issue because the team has provided no details or justification regarding the implementation of mark and unmark.

---

❓ Issue response

Team chose [response.Rejected]

• I disagree

Reason for disagreement: The team claims that the UG states: Students may be specified with either all (i.e. all students), STUDENT_INDEXES or STUDENT_IDS. There is no specification if it means all students within TAssist or all students within the class specified. It is also unlikely a reader would interpret this as all students within TAssist especially since a class must be specified. As the example in the UG states:

This image was also included in my initial bug report. The example states that it only marks all students belonging to the class specified hence it is reasonable to interpret that "all students" in Students may be specified with either all (i.e. all students), STUDENT_INDEXES or STUDENT_IDS refers to all students within the class and NOT all students within TAssist.

1. If the team considers this a type.DocumentationBug I believe that it is still worthy of a severity.Medium as the documentation in the UG is VERY misleading and is not clear of what the intended behaviour should be for the reasons stated above.

2. If the team considers this the intended behaviour of marking all students within TAssist. Then I believe that this is a severity.Medium type.FeatureFlaw in addition to a type.DocumentationBug as there should be no reason why mark attempts to mark ALL students within TAssist rather than just marking the students within the class specified which is a critical design flaw.

I admit that it is my mistake for thinking it is a type.FunctionalityBug as I had thought the team was only trying to mark all students within the class rather than ALL students in TAssist.

---

❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

• I disagree

Reason for disagreement: I disagree that this bug should be considered as low since it is stated that severity.Low bugs are unlikely to affect normal usage of the product, only happen in very rare situations and cause a minor inconvenience only.

I believe that users will use this function often and that the inconvenience and confusion caused are substantial as there should be no reason why the app attempts to unmark students that are not relevant.

If this is the intended functionality of the feature, I would say that this should be a severity.Medium FeatureFlaw as there should be no reason why all students are unmarked when only the students in the class should be unmarked.

---