feat: mark pattern predicates as complete (#216)#230
Conversation
Remove experimental agent teams workflow documentation to simplify the developer guide and focus on core GraphForge development patterns. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Pattern predicates (WHERE inside relationship patterns) are fully implemented and tested. Update documentation to reflect COMPLETE status. Implementation details: - Grammar: cypher.lark:119 (pattern_where rule) - Parser: parser.py:481-484 (RelationshipPattern.predicate) - Executor: executor.py:617-622, 904-918 (predicate evaluation) - Tests: 16 comprehensive integration tests (all passing) Supported features: - Property comparisons (r.since > 2020) - Complex expressions (AND, OR, NOT) - Function calls (length(r.name) = 3) - NULL handling - Variable-length paths with predicates - Undirected relationships - Multiple patterns with different predicates Closes #216 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 38 38
Lines 8075 8075
Branches 1833 1833
=======================================
Hits 7456 7456
Misses 500 500
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Closes #216
Summary
Pattern predicates (WHERE inside relationship patterns) are fully implemented and tested. This PR updates documentation to reflect COMPLETE status.
Implementation Details
Supported Features
✅ Property comparisons (
r.since > 2020)✅ Complex expressions (AND, OR, NOT)
✅ Function calls (
length(r.name) = 3)✅ NULL handling
✅ Variable-length paths with predicates
✅ Undirected relationships
✅ Multiple patterns with different predicates
Testing
All 16 integration tests in
tests/integration/test_pattern_predicates.pypass:Changes
docs/reference/implementation-status/patterns.md: