Skip to content

docs: fix network-analysis.md labels, API methods, and shortestPath note#498

Merged
DecisionNerd merged 1 commit into
mainfrom
docs/477-fix-network-analysis
May 5, 2026
Merged

docs: fix network-analysis.md labels, API methods, and shortestPath note#498
DecisionNerd merged 1 commit into
mainfrom
docs/477-fix-network-analysis

Conversation

@DecisionNerd
Copy link
Copy Markdown
Owner

@DecisionNerd DecisionNerd commented May 5, 2026

Summary

Test plan

  • All Cypher queries use :Node / CONNECTED_TO (matching actual dataset schema)
  • to_dataframe section uses db.to_dataframe(query) — no manual helper
  • NetworkX section uses db.to_networkx() and documents node_label/rel_type filtering
  • shortestPath() note is accurate: raises NotImplementedError, BFS workaround shown
  • make pre-push-fast passes

Closes #477

🤖 Generated with Claude Code


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

…477)

- Fix SNAP ego-facebook dataset labels: :Person/:FRIEND_OF → :Node/:CONNECTED_TO
  (actual labels from snap.json; all 10 query blocks updated)
- Replace manual to_dataframe() helper + nx.DiGraph() loop with shipped API:
  db.to_dataframe(query) and db.to_networkx() / db.to_networkx(node_label=, rel_type=)
- Update shortestPath() note: clarify it raises NotImplementedError and the BFS
  pattern shown is the workaround (aligns with #468 fix)

Closes #477

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • docs/use-cases/network-analysis.md is excluded by !**/*.md, !**/docs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a9aab0b7-61d7-40f6-a988-19cbfaa678c3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/477-fix-network-analysis

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.05%. Comparing base (487632a) to head (463f40c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files          40       40           
  Lines       14513    14513           
  Branches     3439     3439           
=======================================
  Hits        12779    12779           
  Misses       1141     1141           
  Partials      593      593           
Flag Coverage Δ
full-coverage 88.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
parser 95.49% <ø> (ø)
planner 83.07% <ø> (ø)
executor 83.63% <ø> (ø)
storage 91.25% <ø> (ø)
ast 98.22% <ø> (ø)
types 94.75% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487632a...463f40c. Read the comment docs.

@DecisionNerd DecisionNerd merged commit cdc161e into main May 5, 2026
36 checks passed
@DecisionNerd DecisionNerd deleted the docs/477-fix-network-analysis branch May 5, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: fix network-analysis.md — wrong SNAP labels, obsolete export patterns, shortestPath in llm-workflows

1 participant