docs: fix network-analysis.md labels, API methods, and shortestPath note#498
Conversation
…477) - Fix SNAP ego-facebook dataset labels: :Person/:FRIEND_OF → :Node/:CONNECTED_TO (actual labels from snap.json; all 10 query blocks updated) - Replace manual to_dataframe() helper + nx.DiGraph() loop with shipped API: db.to_dataframe(query) and db.to_networkx() / db.to_networkx(node_label=, rel_type=) - Update shortestPath() note: clarify it raises NotImplementedError and the BFS pattern shown is the workaround (aligns with #468 fix) Closes #477 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 88.05% 88.05%
=======================================
Files 40 40
Lines 14513 14513
Branches 3439 3439
=======================================
Hits 12779 12779
Misses 1141 1141
Partials 593 593
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Summary
:Person/FRIEND_OFbutsnap-ego-facebookloads as:Node/CONNECTED_TO(persnap.json); all 10 affected query blocks correctedto_dataframesection showed a manual helper function and anx.DiGraph()loop; replaced withdb.to_dataframe(query)anddb.to_networkx()/db.to_networkx(node_label=, rel_type=)from the shipped v0.3.9 APIshortestPath()note updated — clarified it now raisesNotImplementedError(per fix: shortestPath() causes SyntaxError — parser does not recognise the function #468 fix in fix: shortestPath() / allShortestPaths() parse and raise NotImplementedError #497) and the BFS pattern shown is the intended workaroundTest plan
:Node/CONNECTED_TO(matching actual dataset schema)to_dataframesection usesdb.to_dataframe(query)— no manual helperdb.to_networkx()and documentsnode_label/rel_typefilteringshortestPath()note is accurate: raisesNotImplementedError, BFS workaround shownmake pre-push-fastpassesCloses #477
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.