Fix CodeRabbit configuration schema validation#6
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.coderabbit.yaml (1)
32-44:⚠️ Potential issue | 🔴 Critical
instructionsis not a valid property underreviewsin the v2 schema.The schema defines
"additionalProperties": falsefor thereviewsobject, andinstructions(as a plain array of strings) is not a recognized property. This will produce the same validation warnings the PR aims to fix.To provide review guidance, use
path_instructionswith a wildcard pattern instead:🔧 Proposed fix using path_instructions
- # Custom review instructions for GraphForge - instructions: - - Focus on correctness of openCypher semantics - - Check for proper error handling and type safety - - Verify test coverage for new features - - Ensure docstrings are present for public APIs - - Check for performance implications in query execution - - Validate that changes maintain TCK compliance - - Look for potential security issues (SQL injection patterns, etc.) - - Verify backward compatibility for API changes - - Prefer small, focused PRs (< 300 lines) - - Flag any bandaid fixes or workarounds + # Custom review instructions for GraphForge + path_instructions: + - path: "**/*" + instructions: | + - Focus on correctness of openCypher semantics + - Check for proper error handling and type safety + - Verify test coverage for new features + - Ensure docstrings are present for public APIs + - Check for performance implications in query execution + - Validate that changes maintain TCK compliance + - Look for potential security issues (SQL injection patterns, etc.) + - Verify backward compatibility for API changes + - Prefer small, focused PRs (< 300 lines) + - Flag any bandaid fixes or workarounds
3699a14 to
9a13fa7
Compare
Remove unrecognized properties that caused validation errors: - python (not part of v2 schema) - ignore (use path_filters instead) - tools (not configurable) - file_types (not part of v2 schema) - comments (not part of v2 schema) - thresholds (not part of v2 schema) - integrations (not part of v2 schema) - notifications (not part of v2 schema) Keep only valid v2 schema properties: - language, early_access - reviews (profile, auto_review, path_filters, instructions) - chat Add YAML language server schema reference for editor validation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9a13fa7 to
871fcdc
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.coderabbit.yaml (1)
32-43:⚠️ Potential issue | 🟠 MajorReplace unsupported
reviews.instructions(Line 33) withreviews.path_instructions.
reviewsdisallows unknown keys, so usinginstructionsdirectly will fail schema validation. The supported mechanism ispath_instructions, which accepts a list of path-scoped instruction objects. Restructure your custom review guidance as shown below:✅ Suggested schema‑compliant rewrite
- # Custom review instructions for GraphForge - instructions: - - Focus on correctness of openCypher semantics - - Check for proper error handling and type safety - - Verify test coverage for new features - - Ensure docstrings are present for public APIs - - Check for performance implications in query execution - - Validate that changes maintain TCK compliance - - Look for potential security issues (SQL injection patterns, etc.) - - Verify backward compatibility for API changes - - Prefer small, focused PRs (< 300 lines) - - Flag any bandaid fixes or workarounds + # Custom review instructions for GraphForge + path_instructions: + - path: "**/*" + instructions: | + - Focus on correctness of openCypher semantics + - Check for proper error handling and type safety + - Verify test coverage for new features + - Ensure docstrings are present for public APIs + - Check for performance implications in query execution + - Validate that changes maintain TCK compliance + - Look for potential security issues (SQL injection patterns, etc.) + - Verify backward compatibility for API changes + - Prefer small, focused PRs (< 300 lines) + - Flag any bandaid fixes or workarounds
- Create v0.3.10 release story (#448): NetworkX/igraph export + parse cache - Move #391 to v0.3.10; reorder milestones (#6=v0.3.10, #7=v0.4.0) - README roadmap table: mark v0.3.9 in-progress, add v0.3.10 row - docs/releases/roadmap.md: full rewrite reflecting v0.3.8 released, v0.3.9 in-progress, v0.3.10/v0.4.0/v1.0 planned with accurate scope Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Fixes CodeRabbit configuration file to use only valid v2 schema properties, eliminating validation warnings.
Problem
CodeRabbit was showing validation errors:
Solution
Removed all unrecognized properties and kept only valid v2 schema properties:
❌ Removed (not in v2 schema):
python- Language-specific settings not supportedignore- Usepath_filtersinsteadtools- Tool configuration not exposed in configfile_types- File type handling not configurablecomments- Comment styling not configurablethresholds- Complexity thresholds not configurableintegrations- Integration settings not configurablenotifications- Notification settings not configurable✅ Kept (valid v2 schema):
language,early_accessreviewswith:profile,auto_review,path_filters,instructionschatwithauto_replyChanges
.coderabbit.yamlto minimal valid configurationTesting
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.