Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
image_clustering.pyfile, primarily focused on enhancing the CW-SSIM calculation and adding new imports. Additionally, there is a minor update in the5_cluster.pyfile to adjust the similarity measure options.Enhancements to CW-SSIM calculation:
src/unraphael/dash/image_clustering.py: Implemented the original CW-SSIM algorithm from Wang and Simoncelli, including grayscale conversion, wavelet transform, and detailed computation of the CW-SSIM index. This replaces the previous use ofpyssim.SSIM.Imports and dependencies:
src/unraphael/dash/image_clustering.py: Addedscipy.signalimport to support the wavelet transform in the CW-SSIM calculation.src/unraphael/dash/image_clustering.py: Introduced a fix fortorch.classes.__path__to avoid potential issues with thetorchlibrary path.Updates to similarity measure options:
src/unraphael/dash/pages/5_cluster.py: Removed 'CW-SSIM' from the list of similarity measures available for clustering images, likely due to the changes in its implementation.