-
-
Notifications
You must be signed in to change notification settings - Fork 637
tests: add comprehensive unit tests for linktree module (fixes #300) #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi maintainers! 👋 I've added comprehensive unit tests for the Quick summary:
Happy to make any changes if needed. Thanks for reviewing! |
|
pytest build failed |
|
! I wanted to kindly ask if you could please add the hacktoberfest-accepted label to my pull request in this repo . |
KingAkeem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and runs successfully, great work
|
Could you please mark this PR as “hacktoberfest-accepted” so it counts toward the event? Thank you! |
|
Thank you again for merging my PR! Really appreciate your time and support. |
|
You're welcome and will do, thank you for the contribution. Feel free to tackle anything else that you'd like. |

Summary
This PR adds comprehensive unit tests for the
torbot.modules.linktreemodule as requested in issue #300.Changes
LinkTreeandLinkNodeclassesparse_hostname(),parse_links(),parse_emails(),parse_phone_numbers()tests/conftest.py- test-time shim for NLP classifier (avoids numpy dependency in tests)run_tests.py- helper script for running tests without package installationCoverage
All tests pass (29/29). This PR covers:
Fixes #300
Test Results