Skip to content

Conversation

@edenhaus
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings September 26, 2025 19:26
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Sep 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds map selection functionality by implementing SetMajorMap command and OnMajorMap message handler to enable selecting a specific map by its ID.

  • Adds SetMajorMap command to set/select a major map by ID
  • Adds OnMajorMap message handler for processing major map events from device
  • Updates hardware configurations to use CapabilitySet instead of CapabilityEvent for major map handling

Reviewed Changes

Copilot reviewed 34 out of 35 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/messages/json/test_map.py Adds comprehensive test for OnMajorMap message handler
tests/messages/__init__.py Updates assert_message helper to return HandlingResult for better test validation
tests/commands/json/map/test_major_map.py New test file with parameterized tests for GetMajorMap and SetMajorMap commands
tests/commands/json/map/test_init.py Removes duplicate GetMajorMap test and updates imports
deebot_client/messages/json/map.py Implements OnMajorMap message handler class
deebot_client/messages/json/__init__.py Exports new OnMajorMap class
deebot_client/messages/__init__.py Removes deprecated getMajorMap from message list
deebot_client/hardware/*.py Updates all hardware files to use CapabilitySet for major map capability
deebot_client/commands/json/map/major_map.py New file implementing GetMajorMap and SetMajorMap commands
deebot_client/commands/json/map/__init__.py Reorganizes imports and exports for major map commands
deebot_client/commands/json/__init__.py Exports new SetMajorMap command
deebot_client/capabilities.py Updates capability type from CapabilityEvent to CapabilitySet for major map

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.98%. Comparing base (df20a3c) to head (f7cb07c).
⚠️ Report is 1 commits behind head on dev.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
deebot_client/commands/json/map/major_map.py 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1188      +/-   ##
==========================================
+ Coverage   93.95%   93.98%   +0.02%     
==========================================
  Files         135      136       +1     
  Lines        5162     5184      +22     
  Branches      337      337              
==========================================
+ Hits         4850     4872      +22     
  Misses        248      248              
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 26, 2025

CodSpeed Performance Report

Merging #1188 will not alter performance

Comparing setMajorMap (f7cb07c) with dev (df20a3c)

Summary

✅ 6 untouched

@edenhaus edenhaus merged commit f5efa6c into dev Sep 26, 2025
28 checks passed
@edenhaus edenhaus deleted the setMajorMap branch September 26, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new-feature PR, which adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants