Skip to content

Conversation

@edenhaus
Copy link
Member

@edenhaus edenhaus commented Jan 21, 2025

Performance test will be slower as the map includes now traces of the bot during cleaning

@edenhaus edenhaus added the pr: refactor PR with code refactoring label Jan 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2025

CodSpeed Performance Report

Merging #772 will degrade performances by 72.92%

Comparing improve-map-test (f43d9c6) with dev (aa399fb)

Summary

❌ 1 (👁 1) regressions
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark dev improve-map-test Change
👁 test_get_svg_map 149.9 ms 553.6 ms -72.92%

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (aa399fb) to head (f43d9c6).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #772      +/-   ##
==========================================
+ Coverage   89.61%   89.63%   +0.02%     
==========================================
  Files         111      111              
  Lines        3938     3938              
  Branches      319      319              
==========================================
+ Hits         3529     3530       +1     
  Misses        337      337              
+ Partials       72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edenhaus edenhaus merged commit e43d497 into dev Jan 21, 2025
11 checks passed
@edenhaus edenhaus deleted the improve-map-test branch January 21, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: refactor PR with code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants