refactor(#2801): primary (String) -> Any? overload on LiveShow.from…#78
Merged
Conversation
… + LiveRunner.serve
Adds a primary lambda-taking `from` / `serve` overload alongside the
six existing typed overloads. Future operator types (Swarm, Stage,
Branch-of-Branch, …) call the primary overload directly — no edit to
LiveShow / LiveRunner required:
```kotlin
LiveShow.from(myAgent::invokeSuspend) { theme = LiveShowTheme.NONE }
LiveRunner.serve(myPipeline::invokeSuspend, args)
```
Source-compat preserved — the typed `from(Agent, ...)` / `from(Pipeline, ...)`
/ etc overloads all stay and continue to delegate to the same
`buildShow` / `run` helpers.
Deferred to follow-up (out of scope for this maintainability pass —
flagged honestly):
- `Pipeline.then` 17-overload unification + `StreamableExec` primitive
for consistent emitter threading. Many of the 17 overloads predate
streaming, and #1872's `PipelineSessionExtension` documents the
gap; resolving it cleanly needs a streaming-aware `then` primitive
and a deprecation cycle for non-streaming overloads. Larger than a
maintainability slot.
Full ./gradlew test green; 254+ TEST-*.xml files, zero failures/errors.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… + LiveRunner.serve
Adds a primary lambda-taking
from/serveoverload alongside the six existing typed overloads. Future operator types (Swarm, Stage, Branch-of-Branch, …) call the primary overload directly — no edit to LiveShow / LiveRunner required:Source-compat preserved — the typed
from(Agent, ...)/from(Pipeline, ...)/ etc overloads all stay and continue to delegate to the samebuildShow/runhelpers.Deferred to follow-up (out of scope for this maintainability pass — flagged honestly):
Pipeline.then17-overload unification +StreamableExecprimitive for consistent emitter threading. Many of the 17 overloads predate streaming, and #1872'sPipelineSessionExtensiondocuments the gap; resolving it cleanly needs a streaming-awarethenprimitive and a deprecation cycle for non-streaming overloads. Larger than a maintainability slot.Full ./gradlew test green; 254+ TEST-*.xml files, zero failures/errors.