-
Notifications
You must be signed in to change notification settings - Fork 143
Add version info for run_fastsurfer and into the docker image #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
thanks, but version tags should be read from GitHub (or in the future from the toml file), so that they are only in one place. |
|
sure, and all but the "VERSION_TAG" is read from git, but right now, we do not support this in our git. |
3643fd0 to
e681042
Compare
|
The disadvantage of 2.2.0-dev is that with git hash this looks a bit more ugly: 2.2.0-dev-62df19 vs. 2.2.0dev-62df19 |
406c332 to
2ddc54b
Compare
- get version tag from toml file - create versioned docker images for fastsurfer and tag the newest image as latest
- update code for version extraction
- get version tag from toml file - create versioned docker images for fastsurfer and tag the newest image as latest
- update code for version extraction
write Version to console as well make log dir before making log add .gitignore
|
@LeHenschel finally got the comparison scripts to process everything properly and as I ran both the currently published and this version locally all segmentations and stats files are identical. It might be that some results differ based on the PC, since @AhmedFaisal95 's sample reference_data has differences to my results. |
Add version info for run_fastsurfer and into the docker image
{VERSION_TAG}-{git-hash} ({git-branch}))--version long) also adds md5sums of checkpoints and git status to document difference to most recent git commit