Skip to content

Conversation

@dkuegler
Copy link
Member

@dkuegler dkuegler commented Jun 2, 2023

  • Adds extra option to run_fastsurfer.sh: --version with extra option long
    • outputs a version identifier ({VERSION_TAG}-{git-hash} ({git-branch}))
    • long option (--version long) also adds md5sums of checkpoints and git status to document difference to most recent git commit
  • Add VERSION file to docker images
  • add version to logfile

@m-reuter
Copy link
Member

m-reuter commented Jun 2, 2023

thanks, but version tags should be read from GitHub (or in the future from the toml file), so that they are only in one place.

@dkuegler
Copy link
Member Author

dkuegler commented Jun 2, 2023

sure, and all but the "VERSION_TAG" is read from git, but right now, we do not support this in our git.

@dkuegler
Copy link
Member Author

The disadvantage of 2.2.0-dev is that with git hash this looks a bit more ugly: 2.2.0-dev-62df19 vs. 2.2.0dev-62df19
I think that is why without the extra dash is usually the convention in all open source projects that i like, e.g. pytorch with stuff like 1.14a3 or Firefox with 63.1rc1.

dkuegler and others added 8 commits July 3, 2023 20:05
- get version tag from toml file
- create versioned docker images for fastsurfer and tag the newest image as latest
- update code for version extraction
- get version tag from toml file
- create versioned docker images for fastsurfer and tag the newest image as latest
- update code for version extraction
write Version to console as well
make log dir before making log
add .gitignore
@dkuegler
Copy link
Member Author

dkuegler commented Jul 3, 2023

@LeHenschel finally got the comparison scripts to process everything properly and as I ran both the currently published and this version locally all segmentations and stats files are identical.

It might be that some results differ based on the PC, since @AhmedFaisal95 's sample reference_data has differences to my results.

@dkuegler dkuegler merged commit 9042721 into Deep-MI:dev Jul 3, 2023
@dkuegler dkuegler deleted the feature/version branch July 3, 2023 18:08
dkuegler added a commit to dkuegler/FastSurfer that referenced this pull request Jul 4, 2023
Add version info for run_fastsurfer and into the docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants