This repository was archived by the owner on Sep 14, 2019. It is now read-only.
changed slave controllers to VictorSPX#26
Merged
lhmcgann merged 7 commits intoDeepBlueRobotics:testing-no-autofrom Jan 21, 2018
Merged
changed slave controllers to VictorSPX#26lhmcgann merged 7 commits intoDeepBlueRobotics:testing-no-autofrom
lhmcgann merged 7 commits intoDeepBlueRobotics:testing-no-autofrom
Conversation
lhmcgann
suggested changes
Jan 21, 2018
| PIDMove = new JoystickButton(leftJoy, getButton("PID Move", 7)); | ||
| PIDMove.whenPressed(new PIDMove(40)); | ||
| PIDTurn = new JoystickButton(leftJoy, getButton("PID Turn", 8)); | ||
| PIDTurn.whenPressed(new PIDTurn(30)); |
Contributor
There was a problem hiding this comment.
I'm not big on attaching hard-coded PID commands to joystick buttons. Nelson is working on implementing last year's PID widget (now called PIDget) into this year's code, so can we hold off on doing this/not do it? Victor stuff looks fine though. 👌
Contributor
Author
There was a problem hiding this comment.
For testing reasons before the pidget is done, we still want to test PID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
left framework for TalonSRX in case we switch back.