Add autonomous interfaces to implement#4
Conversation
Added: - commands/Autonomous.java - commands/RunAuto.java - commands/TestAuto.java - and their respective interfaces now we can assign trello cards to people to implement the interfaces
|
wait no don't merge it yet |
used to differentiate between the competition Autonomous command and the command shared by both testing and competition
|
ok all good |
sgayda2
left a comment
sgayda2
left a comment
There was a problem hiding this comment.
I would suggest running eclipse java formatter on the code so its consistent.
| default String getKey(String key) { | ||
| return getClass().getSimpleName() + "/" + key; | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
add new lines at the end of files for consistency
| // arm. | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
I would suggest putting the @OverRide and any other annotations after comments.
There are other files that also have this
ran eclipse format and put @OverRide behind comments
|
Ok, @sgayda2 I did it. |
| * except with a different key - two methods for each kind of getting, with and | ||
| * without default values | ||
| * | ||
| * Directly copied from Robot2017 - kev |
There was a problem hiding this comment.
when making a comment with a name i suggest you use your github account name and style it like this:
kevinzwang@ that way we can always know exactly who and know that its a username
There was a problem hiding this comment.
Lets go with @kevinzwang that way its the same as the github convention
| /** | ||
| * {@inheritDoc} | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
did you use the tools or just hand format? this one seems to be different then the others
There was a problem hiding this comment.
I just used the formatting tool, but yeah that seems like it's spaces instead of tabs
|
Ok, I did those |
2 participants
Added:
now we can assign trello cards to people to implement the interfaces