Conversation
the goal of this new formula is to find a set voltage/joystick value where the robot will be more or less supported statically by the elevator, and use that as the neutral value of the manipulator
brettle
requested changes
Mar 22, 2019
| import edu.wpi.first.wpilibj.smartdashboard.SmartDashboard; | ||
|
|
||
| public class NormalDrive extends Command { | ||
| public class NormalDrive extends InstantCommand { |
Member
There was a problem hiding this comment.
This should really be renamed something like ToggleCharDrive.
Member
Author
|
slow climb was never used and is now obsolete because we have a software limit to our climber elevator |
Member
Author
|
but we should make these aesthetic changes in another pull request |
brettle
approved these changes
Apr 27, 2019
Member
|
@kevinzwang, I've approved, so you should be able to merge now if you feel it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.