-
Notifications
You must be signed in to change notification settings - Fork 0
Make lib199 periodic methods run asynchronously #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
brettle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem fine but I recommend waiting until post-competition to avoid introducing new issues at this point. If there is an issue with thread-safety in the rev code, it may only occur occasionally and would thus be very difficult to debug. I also recommend reaching out to rev to find out if their code is supposed to be thread safe (unless you see that documented somewhere).
I emailed Rev, and they report that "Regarding whether REVLib is thread-safe, it is intended to be thread-safe, yes!" |
If a mock's reference was cleared between IS_REFERENCE_CLEARED.test and CLEAR_INVOCATIONS_ON_REFERENCED_MOCK.accept, the latter would throw an exception. By storing the referenced value in a member variable throughout both operations, the value cannot be null. This change should be tested before being merged into master
|
I'm unfamiliar with how multithreading works so at the moment I'm not sure what to comment on. I trust that Ryan got everything down :) |
To be tested