Skip to content

Conversation

@FriedLongJohns
Copy link
Contributor

Unfortunately I don't think anyone wants to read this, so I left the method as multiple lines.

public static boolean isSparkMaxOveheated(CANSparkMax spark){return spark.getMotorTempurature > spark.TemperatureLimits.get(spark.getDeviceId());}

@FriedLongJohns FriedLongJohns requested a review from CoolSpy3 July 21, 2023 16:37
Copy link
Member

@CoolSpy3 CoolSpy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right idea, but it could be affected by the same bug mentioned in #37. Take a look at the code added in #41. It would also be nice to have methods which accept both the CANSparkMax object as well as its CAN id.

@CoolSpy3 CoolSpy3 added enhancement New feature or request Non-Breaking Change This PR will introduce new backwards-compatible functionality labels Jul 21, 2023
@brettle brettle dismissed CoolSpy3’s stale review May 15, 2024 02:11

The PR does no harm and can be easier than searching log files for the warnings. Further improvements can be made in future PRs.

@brettle brettle merged commit 1b73533 into master May 15, 2024
@brettle brettle deleted the motorOverheatGibber branch May 15, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Non-Breaking Change This PR will introduce new backwards-compatible functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants