Skip to content

DC VSCE 3.0.0#51

Merged
Arvi3d merged 16 commits intomasterfrom
mini-dashboard
Aug 20, 2020
Merged

DC VSCE 3.0.0#51
Arvi3d merged 16 commits intomasterfrom
mini-dashboard

Conversation

@shinin-light
Copy link
Copy Markdown
Contributor

Added analysis dashboard and refactored most of the code.

@shinin-light shinin-light requested a review from Arvi3d August 14, 2020 14:18
@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2020

DeepCode's analysis on #5cfd32 found:

  • ℹ️ 5 minor issues. 👇
  • ✔️ 5 issues were fixed.

Top issues

Description Example fixes
Type string trivially inferred from a string literal, remove type annotation Occurrences: 🔧 Example fixes
Identifier 'loginURL' is never reassigned; use 'const' instead of 'let'. Occurrences: 🔧 Example fixes
Missing semicolon Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

DeepCode's analysis on #5cfd32 found:

  • ℹ️ 5 minor issues. 👇
  • ✔️ 3 issues were fixed.

Top issues

Description Example fixes
Type string trivially inferred from a string literal, remove type annotation Occurrences: 🔧 Example fixes
Identifier 'loginURL' is never reassigned; use 'const' instead of 'let'. Occurrences: 🔧 Example fixes
Properties should be separated by semicolons Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

DeepCode's analysis on #a8c46f found:

  • ℹ️ 2 minor issues. 👇
  • ✔️ 6 issues were fixed.

Top issues

Description Example fixes
Type string trivially inferred from a string literal, remove type annotation Occurrences: 🔧 Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2020

DeepCode's analysis on #a8c46f found:

  • ℹ️ 2 minor issues. 👇
  • ✔️ 6 issues were fixed.

Top issues

Description Example fixes
Type string trivially inferred from a string literal, remove type annotation Occurrences: 🔧 Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

DeepCode's analysis on #5836f1 found:

  • ℹ️ 1 minor issue. 👇
  • ✔️ 6 issues were fixed.

Top issues

Description Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 14, 2020

DeepCode's analysis on #5836f1 found:

  • ℹ️ 1 minor issue. 👇
  • ✔️ 6 issues were fixed.

Top issues

Description Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.603 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.787 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.82 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.473 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.785 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 17, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.78 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Copy link
Copy Markdown
Contributor

@deepcodeg deepcodeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you change the order of the nodes in the feedback panel:
  • first should be send us feedback
  • top 3 faq
  • documentation
  • on-premise
  1. The icons for info and warning seems like they are only different colors. Yep, I noticed the different icon inside :)

Screenshot 2020-08-18 at 16 32 40

  1. Is this possible (don't start it now, but I'm extremely curious if this is possible) - can we have a number next to our app icon?

Screenshot 2020-08-18 at 16 30 49

Comment thread src/deepcode/view/SupportProvider.ts Outdated
collapsed: TreeItemCollapsibleState.Expanded,
children: [
new Node({
text: "1. Here is how to get the most out of DeepCode’s extension",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is how to get the most out of DeepCode’s extension? -> How to get the most out of DeepCode’s extension?

Comment thread src/deepcode/view/SupportProvider.ts Outdated
link: "https://deepcode.freshdesk.com/support/solutions/articles/60000531055-how-can-i-ignore-files-or-directories-"
}),
new Node({
text: "3. Here is how to ignore issues within the code",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is how to ignore issues within the code? -> How to ignore issues within the code?

Comment thread src/deepcode/view/SupportProvider.ts Outdated
return [
new Node({
text: "Contact DeepCode",
description: "Send us a feedback or ask for support",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this node to have only text: "Send us feedback or report a bug". Sounds like it would look like a bit simpler.

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.525 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.608 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.801 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.764 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.7 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.806 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 19, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.741 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 3.741 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ghost
Copy link
Copy Markdown

ghost commented Aug 20, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.422 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@deepcodeappdev
Copy link
Copy Markdown

Congratulations 🎉. DeepCode analyzed your code in 2.167 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@Arvi3d Arvi3d merged commit 702b9a9 into master Aug 20, 2020
@Arvi3d Arvi3d deleted the mini-dashboard branch August 20, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants