Skip to content

dHBV hydrofabric v2.2 unit basin support#29

Merged
taddyb merged 6 commits intomasterfrom
dhbv_integration
Jun 3, 2025
Merged

dHBV hydrofabric v2.2 unit basin support#29
taddyb merged 6 commits intomasterfrom
dhbv_integration

Conversation

@taddyb
Copy link
Collaborator

@taddyb taddyb commented May 18, 2025

Issue Addressed

Adding the dHBV hydrofabric unit catchments from s3://mhpi-spatial to integrate within streamflow reader

Description

Fixes #19

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactor
  • Documentation update

Other (please specify):

Checklist

  • Branch is up to date with master
  • Updated tests or added new tests
  • Tests & pre-commit hooks pass
  • Updated documentation (if applicable)
  • Code follows established style and conventions

@taddyb taddyb requested a review from leoglonz May 18, 2025 04:20
@leoglonz leoglonz self-requested a review May 18, 2025 04:28
@taddyb
Copy link
Collaborator Author

taddyb commented Jun 3, 2025

@leoglonz This code is finally fixed and ready to be deployed. The dHBV hydrofabric forwarding at s3://mhpi-spatial/hydrofabric_v2.2_dhbv_retrospective no longer has duplicates, and the code is running after an epoch:

image

Doing a large-scale training now, but it looks like we're at a new minor version

@taddyb taddyb merged commit f8531a0 into master Jun 3, 2025
@taddyb taddyb deleted the dhbv_integration branch June 3, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration of streamflow inputs / sources into the DDR train code

2 participants