Skip to content

Modify usage endpoint to show v2 responses only#10

Merged
daniel-jones-dev merged 2 commits intomainfrom
gitbook-usage-updates
Mar 14, 2024
Merged

Modify usage endpoint to show v2 responses only#10
daniel-jones-dev merged 2 commits intomainfrom
gitbook-usage-updates

Conversation

@mike-winters-deepl
Copy link
Copy Markdown
Member

No description provided.

@daniel-jones-dev
Copy link
Copy Markdown
Member

  • Should the other two openapi files be kept in sync with this one?
  • Add a line to the changelog? We should say these fields are deprecated and are being removed from the spec.

@mike-winters-deepl
Copy link
Copy Markdown
Member Author

  • Should the other two openapi files be kept in sync with this one?
  • Add a line to the changelog? We should say these fields are deprecated and are being removed from the spec.

@daniel-jones-dev makes sense! I've made these changes in my most recent commit.

@daniel-jones-dev
Copy link
Copy Markdown
Member

Thanks.
I also included the additional info about cost control in character_limit description, for the other two openapi files.
Couple nits about the changelog:

  • when you add a heading in the changelog file, there is an additional footnote-link that has to be added too.
  • Also when you bump the version, you need to bump the versions in the openapi files too.
  • Lastly, you can use a changelog section "Unreleased" until we're ready to bump the version.

I guess these steps need to be documented 🤔 I've modified your changes for the above.

@daniel-jones-dev daniel-jones-dev merged commit 7e5994a into main Mar 14, 2024
@daniel-jones-dev daniel-jones-dev deleted the gitbook-usage-updates branch March 14, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants