Conversation
Move peer-agent registration into a dedicated NanoCtrl Lua script so alias registration is atomic. Duplicate aliases now conflict only within the same scope, while identical aliases in different scopes remain isolated. Also add PeerAgent-side self-alias rejection and tests for scope-isolated discovery with matching aliases across scopes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PeerAgent alias registration and scope discovery behavior in the NanoCtrl control plane.
Motivation
PeerAgent aliases are scoped identifiers. Agents in different scopes should be allowed to use the same alias, but two agents in the same scope should not silently overwrite each other in Redis.
Previously, duplicate aliases could overwrite the same
agent:{alias}key, making two PeerAgents appear as one agent and causing confusing connection/read behavior.Changes
NanoCtrl/lua/register_agent.luafor atomic PeerAgent registration.LuaScripts.connect_to().Validation