Skip to content

fix: fix rms_norm params #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: fix rms_norm params #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lmdeploy/pytorch/kernels/ascend/rms_norm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,13 @@
from torch import Tensor


def rms_norm(hidden_states: Tensor, weight: Tensor, epsilon: float = 1e-6):
return ext_ops.rms_norm(hidden_states, weight, epsilon)
def rms_norm(hidden_states: Tensor,
weight: Tensor,
eps: float = 1e-6,
out: Tensor = None):
rms_norm_out = ext_ops.rms_norm(hidden_states, weight, eps)
if out is None:
out = rms_norm_out
else:
out.copy_(rms_norm_out)
return rms_norm_out