feat(issues): add support for exporting issues to SARIF#104
Merged
siddhant-deepsource merged 7 commits intoFeb 23, 2022
Conversation
* add SARIF exporter Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
* add tests for SARIF exporter * refactor tests to reduce redundancy Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
* fix rule index updation * add new test case for multi-language repos Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
siddhant-deepsource
previously approved these changes
Feb 23, 2022
Contributor
siddhant-deepsource
left a comment
siddhant-deepsource
left a comment
There was a problem hiding this comment.
Just some minor nits. Otherwise, looks good. Great work @burntcarrot 👏
siddhant-deepsource
approved these changes
Feb 23, 2022
This was referenced Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #95
Signed-off-by: burntcarrot aadhav.n1@gmail.com