feat(issues): add file and directory based issue filtering#106
Merged
siddhant-deepsource merged 9 commits intoFeb 25, 2022
Conversation
* add directory based issue filtering * fix panic while fetching issues related to a file Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
burntcarrot
commented
Feb 24, 2022
burntcarrot
commented
Feb 24, 2022
burntcarrot
commented
Feb 24, 2022
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
* fix issue de-duplication * refactor utilities Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Contributor
siddhant-deepsource
left a comment
siddhant-deepsource
left a comment
There was a problem hiding this comment.
This looks almost ready. Have made couple of comments. PTAL. Also, would be great if you can add some tests for this.
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Contributor
Author
|
Adding tests. |
* add tests for issue filtering * add dummy issue data for tests Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Contributor
|
The test-coverage reporting seems to work now. |
siddhant-deepsource
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #98.
Adds directory based issue filtering (both single and multiple directories):
File-based issue filtering is also supported (both single and multiple files):
Combinations of both files and directories are also supported:
Signed-off-by: burntcarrot aadhav.n1@gmail.com