Skip to content

tests(deepsource): add tests for analyzer API#130

Merged
siddhant-deepsource merged 3 commits into
DeepSourceCorp:masterfrom
burntcarrot:test-analyzers
Apr 13, 2022
Merged

tests(deepsource): add tests for analyzer API#130
siddhant-deepsource merged 3 commits into
DeepSourceCorp:masterfrom
burntcarrot:test-analyzers

Conversation

@burntcarrot
Copy link
Copy Markdown
Contributor

Closes: #116.

Adds unit tests for the Analyzers API inside the deepsource package.

Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
@siddhant-deepsource
Copy link
Copy Markdown
Contributor

siddhant-deepsource commented Apr 11, 2022

What do you think about moving the tests to a tests folder in deepsource folder? Will help to use the init_test.go functionality in tests of every package withing deepsource.

Something like deepsource/tests/analyzers/get_analyzer_test.go?

Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Copy link
Copy Markdown
Contributor

@siddhant-deepsource siddhant-deepsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burntcarrot
Copy link
Copy Markdown
Contributor Author

@sourya-deepsource Could you please do a review?

@siddhant-deepsource siddhant-deepsource merged commit 47c32ad into DeepSourceCorp:master Apr 13, 2022
@burntcarrot burntcarrot deleted the test-analyzers branch July 25, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Test analyzers API

3 participants