Add global --skip-tls-verify flag for self-signed certs#272
Merged
sourya-deepsource merged 5 commits intomasterfrom Mar 10, 2026
Merged
Add global --skip-tls-verify flag for self-signed certs#272sourya-deepsource merged 5 commits intomasterfrom
sourya-deepsource merged 5 commits intomasterfrom
Conversation
Contributor
jai-deepsource
commented
Mar 2, 2026
- Add --skip-tls-verify persistent flag on root command, available to all subcommands
- Resolution priority: CLI flag > DEEPSOURCE_SKIP_TLS_VERIFY env var > config file
- Add SkipTLSVerify field to CLIConfig, persisted as skip_tls_verify in TOML
- Wire all commands (issues, metrics, runs, reportcard, vulnerabilities, auth) to pass resolved value to API client
- Build custom http.Transport with InsecureSkipVerify when enabled
- Deprecate report's --skip-verify flag in favor of the global flag
- Pass SkipTLSVerify through auth service for device registration and PAT requests
- Add tests for TLS resolution logic, config env/file loading, client transport, and login behavior
- Remove .deepsource.toml
- Add --skip-tls-verify persistent flag on root command, available to all subcommands - Resolution priority: CLI flag > DEEPSOURCE_SKIP_TLS_VERIFY env var > config file - Add SkipTLSVerify field to CLIConfig, persisted as skip_tls_verify in TOML - Wire all commands (issues, metrics, runs, reportcard, vulnerabilities, auth) to pass resolved value to API client - Build custom http.Transport with InsecureSkipVerify when enabled - Deprecate report's --skip-verify flag in favor of the global flag - Pass SkipTLSVerify through auth service for device registration and PAT requests - Add tests for TLS resolution logic, config env/file loading, client transport, and login behavior - Remove .deepsource.toml
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Feedback
- [No single canonicalization boundary]
- Inputs are accepted and interpreted differently across subsystems, letting subtle edge cases (addresses, paths, attribute URLs) behave inconsistently; normalize and validate untrusted data once at the boundary, then propagate canonical values to every layer.
- [Parsing and escaping duplicated across layers]
- Multiple ad‑hoc parsers/escapers cause divergent behavior on corners; extract and centralize robust parsing/escaping primitives, provide thin validated wrappers, and replace in-place logic to prevent inconsistent interpretations.
- [Corner cases missing from automated tests]
- Low-severity bugs recur because IPv6 literals, root-escape paths, and template-attribute contexts aren’t exercised; add targeted unit, table-driven, and fuzz/property tests for parsing, path resolution, and HTML contexts to catch regressions early.
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go | Mar 10, 2026 6:20a.m. | Review ↗ | |
| Secrets | Mar 10, 2026 6:20a.m. | Review ↗ | |
| Test coverage | Mar 10, 2026 6:20a.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 27.3% [⤫ below threshold] |
21.7% [▲ up 2.3% from master] |
| Go | 27.3% [⤫ below threshold] |
21.7% [▲ up 2.3% from master][✓ above threshold] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sourya-deepsource
approved these changes
Mar 10, 2026
parth-deepsource
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.