Skip to content

fix: export parameters #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shivam-deepsource merged 6 commits into from
Feb 22, 2022
Merged

fix: export parameters #6

shivam-deepsource merged 6 commits into from
Feb 22, 2022

Conversation

@shivam-deepsource
Copy link
Contributor

@shivam-deepsource shivam-deepsource commented Feb 21, 2022 •
edited
Loading

This PR makes the following changes

  1. Export to index.* instead of shifty.*
  2. Set ES target version to 2018 instead of ESNext
  3. Update package name
  4. Update export files in package.json

@shivam-deepsource shivam-deepsource changed the title fix: export paramters fix: export parameters Feb 21, 2022
yash-deepsource
yash-deepsource reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@yash-deepsource yash-deepsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion, rest changes LGTM.

@shivam-deepsource @yash-deepsource
chore: apply suggestions
1eea0d9 
Co-authored-by: Yash Dave <87606277+yash-deepsource@users.noreply.github.com>
@shivam-deepsource shivam-deepsource merged commit a5074f1 into master Feb 22, 2022
@shivam-deepsource shivam-deepsource deleted the fix-exports branch February 22, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yash-deepsource yash-deepsource yash-deepsource approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shivam-deepsource @yash-deepsource