Conversation
There was a problem hiding this comment.
Replace all instances of Union[...] with |
Ensure all classes support both Image and np.ndarray, including lists of each (list[Image] and list[np.ndarray]). Update type hints in method signatures accordingly as well as in the Methods section of the docstring.
cmanzo
left a comment
There was a problem hiding this comment.
Remove imports of List, Dict, and other generics from typing, using built-in list, dict, etc., instead.
cmanzo
left a comment
There was a problem hiding this comment.
Ensure that "Examples" is always used in the plural form, consistent with "Methods" and "Parameters".
Additionally, all example code should follow the standard of importing deeptrack as dt and referencing dt.Image, etc.
@giovannivolpe please confirm that you like the latter choice
|
Implemented feedback except for examples import statements. I think in the examples of the |
@giovannivolpe what do you think? |
Yes, I think it makes sense, so that readers can just cut and paste and it's clearly identified what is part of DeepTrack2. |
Yes, I think we can make exceptions if this makes the code clearer, especially when we have long names or we refer to the class being commented itself. |
Imageinstead of'Image'