Skip to content

Feature/FeeManager#92

Merged
avernikoz merged 48 commits intomainfrom
feature/fees-manager
Aug 8, 2025
Merged

Feature/FeeManager#92
avernikoz merged 48 commits intomainfrom
feature/fees-manager

Conversation

@bathord
Copy link
Copy Markdown
Collaborator

@bathord bathord commented Aug 4, 2025

No description provided.

@bathord bathord changed the title [WIP] Feature/FeesManager Feature/FeesManager Aug 6, 2025
Comment thread docs/unsettled-fees.md Outdated
Comment thread docs/unsettled-fees.md Outdated
Comment thread docs/unsettled-fees.md Outdated
Comment thread packages/deeptrade-core/sources/fees_manager.move Outdated
Comment thread packages/deeptrade-core/sources/order.move
Comment thread packages/deeptrade-core/sources/swap.move
Comment thread packages/deeptrade-core/sources/order.move Outdated
@avernikoz
Copy link
Copy Markdown
Collaborator

avernikoz commented Aug 7, 2025

  1. Shouldn't we have "borrow_mut" for claiming our protocol fees? Because if we will do it frequently, we'll make gas fees higher for unlucky random users? (I believe it's for withdraw_protocol_fee)

@avernikoz
Copy link
Copy Markdown
Collaborator

  1. Mb rename "FeesManager" to "FeeManager"?

@bathord bathord changed the title Feature/FeesManager Feature/FeeManager Aug 7, 2025
@avernikoz avernikoz merged commit a65babe into main Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants