Continued work on activity stream #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: send events on security key ops
TODO: handle removed
wojcik91
approved these changes
Jun 2, 2025
wojcik91
approved these changes
Jun 2, 2025
| pub struct DeviceModifiedMetadata { | ||
| pub device_names: Vec<String>, | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think it makes sense to put those into a separate module
j-chmielewski
added a commit
that referenced
this pull request
Jun 3, 2025
* activity mock UI * add basic skeleton of the event model * add basic handlder skeleton with pagination * a bit of cleanup * update query data * sketch out general event service setup * inifnite scroll audit log with next page detection * implement a basic loop for the event logger * implement base event logging flow * add helper method for sending events * remove unnecessary DB pool from mail handler * refactor logger message and add helper to log events * add router module documentation * split router logic into smaller functions * milify list count display * reorder migrations * add filtering by modules * implement sorting * add username to audit log event * add sorting by IP * linter fixes * remove details column * add EventType enum * update query data * change default sort order * add search support * add search support * store username in audit log table * update dependencies * filter events for non-admin users * Update defguard-ui * upgrade web packages * fix missing package * fix username query filter * remove FK constraint to avoid deletions * add user id to audit log events * add device-related logging * expect UTC timestamp in API request query param * refactor group filters modal to accept string vlaues * fix params parsing for axum compatible arrays * add time filtering to activity view * display timestamp in activity list as local time * fix timestamp formatting in activity list * add search to activity list * add more logger event types * add placeholder logic * Translate event type and module in activtivy list * extract router and logger into separate crates * setup event channels for grpc servers * pass event tx to bidi services * Continued work on activity stream (#1186) * DRY ApiEvent struct * Handle device add/modified/removed events * User event variants, impl FromRequestParts for ApiRequestContext * Use context from request parts for all User events * Refactor handle_api_event method * MFA enabled/disabled events * Totp, email, mfa security key events TODO: send events on security key ops * Don't rename owner field * NetworkDevice Added/Modified/Removed events TODO: handle removed * Add network device frontend types and translations * NetworkDevice event handling * Cargo fmt * Use context extractor in add_user handler * Metadata handling is going to change, skip filtering over it for now * Handle network device edge-cases * Cache SessionInfo in extractors for downstream use * Move audit log metadata to separate module * Remove unused import * Linter fixes * Allow dead code * Mark unused variables * Add event router and logger to cargo-deny license exceptions * Fix integration tests - rx dropped before tests end * Fix logout handler --------- Co-authored-by: Filip Ślęzak <fslezak@teonite.com> Co-authored-by: Maciej Wójcik <maciek@wjck.pl> Co-authored-by: Filip Ślęzak <102536422+filipslezaklab@users.noreply.github.com> Co-authored-by: Jacek Chmielewski <jchmielewski@teonite.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.