feat(aws): use DEFANG_AWS_APN_ID for AWS resource tagging#2155
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe PR adds ChangesAWS APN ID attribution
Sequence Diagram(s)sequenceDiagram
participant CanIUseResponse
participant ByocBaseClient
participant runCdCommand
CanIUseResponse->>ByocBaseClient: set AwsApnId from aws_apn_id
ByocBaseClient->>runCdCommand: expose CanIUseConfig.AwsApnId
runCdCommand->>runCdCommand: populate DEFANG_AWS_APN_ID
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=warning msg="The linter 'gomodguard' is deprecated (since v2.12.0) due to: new major version. Replaced by gomodguard_v2." Comment |
required when aws-apn-id gets removed; see #2155
Description
Introduce
DEFANG_AWS_APN_IDenvironment variable, passed to CD task for tagging AWS resources during AWS deployments. Addedaws_apn_idtoCanIUserpc response for customers that bought Defang Pro through the AWS Marketplace.Linked Issues
Fixes #2154
Checklist
Summary by CodeRabbit
New Features
Documentation