Ruff: Add and fix ARG003,4,5

[kiblik]

Fix some ruff ARG rules https://docs.astral.sh/ruff/rules/#flake8-unused-arguments-arg

[dryrunsecurity]

DryRun Security Summary

The provided code changes cover a variety of files and functionality within the Dojo application, including updates to security scan parsers, improvements to date range filtering, cleanup of system settings middleware, addition of new Ruff linting rules, and reorganization of the URL routing configuration, without introducing any obvious security vulnerabilities.

Expand for full summary

Summary:

The provided code changes cover a variety of files and functionality within the Dojo application, a Django-based web application. The changes include updates to the Nexpose and Veracode security scan parsers, improvements to the date range filtering functionality, cleanup of the system settings middleware, addition of new Ruff linting rules, and reorganization of the URL routing configuration.

From an application security perspective, the changes do not appear to introduce any obvious security vulnerabilities. The updates to the security scan parsers are focused on improving the handling and mapping of identified vulnerabilities, which is an important security-related functionality. The date range filtering changes and middleware cleanup are also not expected to have a direct impact on the application's security posture.

However, it is important to review the entire codebase and understand the context in which these changes are being made. Aspects such as input validation, error handling, logging, and authentication/authorization should be carefully evaluated to ensure the overall security of the application. Additionally, the new Ruff linting rules suggest a focus on secure coding practices, which is a positive sign, but the specific details and implementation of these rules should be reviewed.

Files Changed:

1. dojo/tools/nexpose/parser.py: The changes remove the test parameter from the findings() method calls, which does not appear to have a significant impact on the security of the application.
2. dojo/tools/veracode/xml_parser.py: The changes rename the vendor parameter to _vendor in the __xml_sca_flaw_to_finding method, which is part of the implementation for parsing and processing Veracode Software Composition Analysis (SCA) findings.
3. dojo/filters.py: The changes update the DateRangeFilter and DateRangeOmniFilter classes to include new date range options, improving the functionality and flexibility of the date range filtering capabilities.
4. dojo/middleware.py: The changes include the addition of a # noqa: ARG003 comment to suppress a specific Flake8 warning, and the code appears to be focused on the cleanup of the system_settings object.
5. ruff.toml: The changes add three new Ruff rule identifiers ("ARG003", "ARG004", and "ARG005") to the select list, suggesting a focus on improving secure coding practices and input validation.
6. dojo/urls.py: The changes update the robots.txt URL configuration and reorganize the URL patterns into different modules, improving the maintainability and organization of the URL routing configuration.

Code Analysis

We ran 9 analyzers against 6 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer	Findings
Sensitive Files Analyzer	1 finding

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

[mtesauro]

Approved

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.