Fix deterministic ordering for async_dupe_delete when duplicate dates tie#14562
Merged
Maffooch merged 2 commits intoDefectDojo:bugfixfrom Mar 23, 2026
Merged
Conversation
order_by("date") does not define order for rows with identical dates.
Add id as secondary sort so async_dupe_delete removes oldest duplicates
first (by date, then id), matching documented behavior.
Add test_delete_duplicate_order_same_date_tiebreak_by_id; lower-id duplicate is removed first when max_dupes is exceeded and date ties.
Maffooch
approved these changes
Mar 20, 2026
Jino-T
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excess duplicates are deleted in chronological order, oldest are deleted, newest are retained. In cases where many duplicates had the same
datethe order of deletion wasundefined. This PR as explicit fallback ordering toid.date, thenid, so deletion removes the oldest duplicates first when many rows share the samedate(e.g. scanner-provided dates).async_dupe_deletewith documented behavior: delete the oldest duplicate findings until the configured maximum is satisfied.[sc-12922]