sla_deadline doesn't work with mitigated findings#8279
Merged
mtesauro merged 1 commit intoDefectDojo:bugfixfrom Jun 28, 2023
Merged
sla_deadline doesn't work with mitigated findings#8279mtesauro merged 1 commit intoDefectDojo:bugfixfrom
mtesauro merged 1 commit intoDefectDojo:bugfixfrom
Conversation
coheigea
force-pushed
the
coheigea/sla-date
branch
from
ae9db4d to
21671ef
Compare
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
coheigea
force-pushed
the
coheigea/sla-date
branch
from
21671ef to
4049214
Compare
Contributor
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
coheigea
force-pushed
the
coheigea/sla-date
branch
from
4049214 to
8f07053
Compare
Contributor
Author
|
@Maffooch I think I accidentally submitted this originally against master. How can I force the checks to run again, now that I rebased against bugfix? |
Contributor
|
Testing on a different day to make sure results are consistent |
grendel513
approved these changes
Jun 28, 2023
blakeaowens
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The sla_deadline function doesn't work with mitigated findings, as it just applies sla days remaining to the current date, instead of the mitigated date.
Also I added a mitigated date for the Veracode SCA parser when findings are mitigated, as the date isn't contained in the JSON.
Test results
New tests added in PR.