add check for dune dependecies, only run after 6 AM UTC for v1 adapters #10757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e v1 reload logic
g1nt0ki
reviewed
Oct 4, 2025
| // Edge case: V2 adapter has yesterday data but it was updated before end of yesterday (incomplete day) | ||
| // Valid update window: 00:00 UTC (today) - 01:00 UTC (today) = fresh data, no refill needed | ||
| // If updatedAt < 00:00 UTC today (i.e., from yesterday), reload after 01:00 UTC today | ||
| if (!runAtCurrTime && haveYesterdayData && yesterdayDataMap.has(id2)) { |
Member
There was a problem hiding this comment.
was thinking, what if this logic to storeAll instead, my worry is, this script/file is already complex and the new code is applicable only to store-all task.
was thinking along the lines of, not passing today's data if we want to refill today, and similar for yesterday's data based on the checks in this PR, wdyt?
…into dune-dependencies
g1nt0ki
reviewed
Oct 6, 2025
| // Edge case 2: V1 DUNE adapters with data updated before 08:00 UTC | ||
| // Only applies to V1 adapters with DUNE dependencies | ||
| // Remove from set to trigger refill after 08:00 UTC | ||
| if (includeInSet && isV1 && hasDune && yesterdayRecord.updatedAt && isAfter8AM) { |
Member
There was a problem hiding this comment.
rename as hasDuneDependency to be more clear? (can ignore)
g1nt0ki
reviewed
Oct 6, 2025
| } | ||
| } | ||
| } catch (e) { | ||
| // If we can't load module, include by default to avoid breaking existing adapters |
Member
There was a problem hiding this comment.
can you add error logging here, so we could look into it if code ever reaches here
g1nt0ki
previously approved these changes
Oct 6, 2025
g1nt0ki
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each protocol:
Check if yesterday record exists
Load adapter to get version, runAtCurrTime, dependencies
Edge case 1 (V2 incomplete data):
Edge case 2 (V1 DUNE refresh):
Otherwise: Add to set → Skips in handler2