Conversation
On tablets (shortestSide >= 600), present the add site options as a centered dialog instead of a modal bottom sheet. This avoids barrier dismiss issues on iPad and is more consistent with tablet UX. Also removes DraggableScrollableSheet wrapper in favor of Column + shrinkWrap ListView for proper content sizing in both presentations.
johnmaguire
previously approved these changes
Mar 5, 2026
johnmaguire
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jasikpark reported an issue with iPad on 26.x immediately dismissing the add site bottom sheet. The issue there stemmed from the previous version on iOS 26.x, upgrading has fixed the issue in my testing.
This also moves the add site from a bottom sheet to a dialog on iPad:
iPhone remains the same:
