Conversation
nbrownus
changed the title
… summaries, empty match by states when switching type
johnmaguire
reviewed
Mar 24, 2026
johnmaguire
approved these changes
Mar 24, 2026
Member
johnmaguire
left a comment
johnmaguire
left a comment
There was a problem hiding this comment.
LGTM - I did play with the UI a bit on Android and it felt good.
johnmaguire
approved these changes
Mar 24, 2026
Member
johnmaguire
left a comment
johnmaguire
left a comment
There was a problem hiding this comment.
LGTM - I did play with the UI a bit on Android and it felt good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a way to manage the firewall rules in UI. Extra review is needed for the firewall rules and rule screen as well as the site model.
Supersedes #354 and #358
Fully speaks to #45 and #61