[@types/carbon-components-react] Bump to 7.6, type updates & fixes.#38983
[@types/carbon-components-react] Bump to 7.6, type updates & fixes.#38983armanio123 merged 12 commits intoDefinitelyTyped:masterfrom kalbert312:ccr-fixes-2019-10-08
Conversation
| menuOffset?: | ||
| MenuOffsetData | ||
| | ((menuBody: HTMLElement, menuDirection: TooltipProps['direction']) => Required<MenuOffsetData> | undefined); |
There was a problem hiding this comment.
Note: The linter was producing bad code for this. I was getting menuOffset?: | MenuOffsetData | (parenthesized fn)
There was a problem hiding this comment.
Now I'm wondering if it's because of the non-parenthesized return result of the fn....
There was a problem hiding this comment.
Just checked. Running git hook on
menuOffset?:
MenuOffsetData
| ((menuBody: HTMLElement, menuDirection: TooltipProps['direction']) => (Required<MenuOffsetData> | undefined));produced
menuOffset?:
| MenuOffsetData
| ((menuBody: HTMLElement, menuDirection: TooltipProps['direction']) => Required<MenuOffsetData> | undefined);|
@kalbert312 Thank you for submitting this PR! Pull requests from definition owners are typically merged after quick review from a DefinitelyTyped maintainer once the CI passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
|
Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
|
👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics. Let’s review the numbers, shall we?
First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt. It looks like there are several metrics that changed quite a bit. You might want to take a look and make sure your changes won’t cause slow-downs for users consuming these types. If you have any questions or comments about me, you can ping |
|
I just published |
…efinitelyTyped#38983) * Bump to 7.6. * Fix missing required id prop. * Update InlineLoading. * Update ToolbarSearch. * Update Tooltip. * Update SideNav props. * Update Notification. * Improve DataTable types. * Lint fix. * Fix extra new line. * Reverting children type change on SideNav components due to carbon issue. * Lint fix.
…efinitelyTyped#38983) * Bump to 7.6. * Fix missing required id prop. * Update InlineLoading. * Update ToolbarSearch. * Update Tooltip. * Update SideNav props. * Update Notification. * Improve DataTable types. * Lint fix. * Fix extra new line. * Reverting children type change on SideNav components due to carbon issue. * Lint fix.
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If changing an existing definition: