Skip to content

[react-table] remove UseFiltersOptions#42090

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
gargroh:patch-3
Feb 10, 2020
Merged

[react-table] remove UseFiltersOptions#42090
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
gargroh:patch-3

Conversation

@gargroh
Copy link
Copy Markdown
Contributor

@gargroh gargroh commented Feb 4, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@gargroh gargroh changed the title remove UseFiltersOptions [react-table] remove UseFiltersOptions Feb 4, 2020
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Feb 4, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 4, 2020

@gargroh Thank you for submitting this PR!

🔔 @ggascoigne @stramel - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #42090 diff
Batch compilation
Memory usage (MiB) 127.8 117.2 -8.3%
Type count 25948 25948 0%
Assignability cache size 54321 54321 0%
Language service
Samples taken 996 996 0%
Identifiers in tests 996 996 0%
getCompletionsAtPosition
    Mean duration (ms) 618.5 614.1 -0.7%
    Mean CV 8.1% 7.7%
    Worst duration (ms) 920.4 821.6 -10.7%
    Worst identifier value skipPageResetRef
getQuickInfoAtPosition
    Mean duration (ms) 612.0 609.3 -0.4%
    Mean CV 8.0% 8.2% +1.4%
    Worst duration (ms) 835.3 824.7 -1.3%
    Worst identifier skipPageReset option

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Unmerged The author did not merge the PR when it was ready. labels Feb 4, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 9, 2020

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Feb 9, 2020
@sandersn sandersn merged commit 01e74ed into DefinitelyTyped:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants