Skip to content

feat(passport-azure-ad): Added cookieSameSite option to IOIDCStrategyOption#42115

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
benbakhar:passport-aad-cookie-samesite
Feb 10, 2020
Merged

feat(passport-azure-ad): Added cookieSameSite option to IOIDCStrategyOption#42115
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
benbakhar:passport-aad-cookie-samesite

Conversation

@benbakhar
Copy link
Copy Markdown
Contributor

@benbakhar benbakhar commented Feb 5, 2020

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Provide a URL to documentation or source code which provides context for the suggested changes: AzureAD/passport-azure-ad@cf04a06

@typescript-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #42115 diff
Batch compilation
Memory usage (MiB) 64.3 63.6 -1.0%
Type count 10713 10713 0%
Assignability cache size 3425 3425 0%
Language service
Samples taken 78 78 0%
Identifiers in tests 78 78 0%
getCompletionsAtPosition
    Mean duration (ms) 292.1 292.9 +0.2%
    Mean CV 13.0% 12.4%
    Worst duration (ms) 349.8 335.4 -4.1%
    Worst identifier redirectUrl passReqToCallback
getQuickInfoAtPosition
    Mean duration (ms) 288.1 292.9 +1.7%
    Mean CV 12.0% 13.1% +9.6%
    Worst duration (ms) 344.3 364.5 +5.9%
    Worst identifier bearerStrategyOptions IOIDCStrategyOptionWithRequest

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Feb 5, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 5, 2020

@benbakhar Thank you for submitting this PR!

🔔 @ShekharNain - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Feb 5, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@sandersn sandersn merged commit 3aa4aff into DefinitelyTyped:master Feb 10, 2020
@benbakhar benbakhar deleted the passport-aad-cookie-samesite branch February 13, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants