Skip to content

feat(slonik): update types to v22.1#42144

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
n1ru4l:patch-2
Feb 11, 2020
Merged

feat(slonik): update types to v22.1#42144
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
n1ru4l:patch-2

Conversation

@n1ru4l
Copy link
Copy Markdown
Contributor

@n1ru4l n1ru4l commented Feb 6, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.

  • Test the change in your own code. (Compile and run.)

  • Add or edit tests to reflect the change. (Run with npm test.)

  • Follow the advice from the readme.

  • Avoid common mistakes.

  • Run npm run lint package-name (or tsc if no tslint.json is present).

  • Provide a URL to documentation or source code which provides context for the suggested changes: gajus/slonik@v21.4.2...v22.1.0

  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to slonik with its source on master.

Comparison details 📊
Batch compilation
Type count 9891
Assignability cache size 3129
Language service measurements
Samples taken 402
Identifiers in tests 402
getCompletionsAtPosition
    Mean duration (ms) 287.3
    Mean CV 10.7%
    Worst duration (ms) 353.8
    Worst identifier other
getQuickInfoAtPosition
    Mean duration (ms) 287.7
    Mean CV 10.8%
    Worst duration (ms) 371.8
    Worst identifier any
System information
Node version v12.14.1
CPU count 2
CPU speed 2.095 GHz
CPU model Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1066-azure

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 6, 2020

@n1ru4l Thank you for submitting this PR!

🔔 @sebald @mmkal - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Feb 11, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Feb 11, 2020

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Feb 11, 2020
@sandersn sandersn merged commit 18a7000 into DefinitelyTyped:master Feb 11, 2020
@n1ru4l n1ru4l deleted the patch-2 branch February 11, 2020 17:36
@n1ru4l
Copy link
Copy Markdown
Contributor Author

n1ru4l commented Feb 11, 2020

thx 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants