Fix typings in @reach/router to include innerRef#43367
Fix typings in @reach/router to include innerRef#43367uniqueiniquity merged 2 commits intoDefinitelyTyped:masterfrom
Conversation
https://reach.tech/router/api/Link > ## innerRef: func > Calls up with its inner ref for apps on React <16.4. > If using React >=16.4, use ref instead. > > ``` > <Link to="./" innerRef={node => /* ... */} /> > ```
|
@Eyas Thank you for submitting this PR! 🔔 @kingdaro @xMokAx @awwit @wroughtec @chilledoj - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
@Eyas - It appears Travis did not correctly run on this PR! /cc @RyanCavanaugh to investigate and advise. |
|
@sandersn @RyanCavanaugh Travis has been running for a day, locally, I'm starting to think there's an infintie loop somewhere in the dependency testing, could that be? |
|
hm actually the travis link shows this completed successfully since yesterday, but still shows up here as running. |
|
Odd, because the bot removed the tag, so it also noticed that Travis succeeded. |
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
https://reach.tech/router/api/Link
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed. N/A