[mongodb] Fix bulkWrite operation types#45492
[mongodb] Fix bulkWrite operation types#45492typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
@avaly Thank you for submitting this PR! Code ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 45492,
"author": "avaly",
"owners": [
"CaselIT",
"alanmarcell",
"dante-101",
"mcortesi",
"EnricoPicci",
"AJCStriker",
"julien-c",
"daprahamian",
"denys-bushulyak",
"BastienAr",
"sindbach",
"geraldinelemeur",
"various89",
"angela-1",
"hector7",
"floric",
"erikc5000",
"Manc",
"jloveridge",
"ranguna",
"HosseinAgha",
"albertossilva",
"peterblazejewicz",
"LinusU",
"taxilian",
"xamgore",
"avaly",
"HitkoDev",
"jtassin"
],
"dangerLevel": "ScopedAndTested",
"headCommitAbbrOid": "0a788da",
"headCommitOid": "0a788dafce2afd5d1b9eaa19bb9276c6a71f007a",
"mergeIsRequested": true,
"stalenessInDays": 1,
"lastCommitDate": "2020-06-18T14:46:38.000Z",
"lastCommentDate": "2020-06-19T16:18:27.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/45492/files",
"hasMergeConflict": false,
"authorIsOwner": true,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"mongodb"
],
"files": [
{
"filePath": "types/mongodb/index.d.ts",
"kind": "definition",
"package": "mongodb"
},
{
"filePath": "types/mongodb/test/collection/bulkWrite.ts",
"kind": "test",
"package": "mongodb"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-06-19T16:10:38.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 2,
"isChangesRequested": false
} |
|
🔔 @CaselIT @alanmarcell @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian @Denys-Bushulyak @bastienar @sindbach @geraldinelemeur @various89 @angela-1 @hector7 @floric @erikc5000 @Manc @jloveridge @Ranguna @HosseinAgha @albertossilva @peterblazejewicz @LinusU @taxilian @xamgore @HitkoDev @jtassin - please review this PR in the next few days. Be sure to explicitly select |
|
Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files. mongodb (unpkg)was missing the following properties:
The most common way to resolve this error is to use 'export =' syntax.
as well as these 11 other properties...BulkWriteError, Admin, Collection, GridStore, Chunk, CoreServer, CoreConnection, Map, Symbol, BSONRegExp, instrument |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
1f7c000 to
0a788da
Compare
|
@avaly Everything looks good here. Great job! I am ready to merge this PR on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
|
Ready to merge |
|
I just published |
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).If changing an existing definition:
Changes in this PR:
insertOneoperations should also accept objects without_id- these will get a new_idgenerated by mongo server