[i18next-fs-backend] create definitions#47072
[i18next-fs-backend] create definitions#47072elibarzilay merged 2 commits intoDefinitelyTyped:masterfrom Quantumlyy:i18next-fs-backend
Conversation
|
@QuantumlyTangled Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment which I will keep updated. 1 package in this PRCode ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47072,
"author": "QuantumlyTangled",
"owners": [],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "99c0bd0",
"headCommitOid": "99c0bd0b5597a2bd83d5c2f0045a6ac996869f39",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastPushDate": "2020-08-27T09:02:55.000Z",
"lastCommentDate": "2020-08-27T09:02:55.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47072/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": true,
"popularityLevel": "Well-liked by everyone",
"newPackages": [
"i18next-fs-backend"
],
"packages": [
"i18next-fs-backend"
],
"files": [
{
"path": "types/i18next-fs-backend/i18next-fs-backend-tests.ts",
"kind": "test",
"package": "i18next-fs-backend"
},
{
"path": "types/i18next-fs-backend/index.d.ts",
"kind": "definition",
"package": "i18next-fs-backend"
},
{
"path": "types/i18next-fs-backend/package.json",
"kind": "package-meta",
"package": "i18next-fs-backend",
"suspect": "edited"
},
{
"path": "types/i18next-fs-backend/tsconfig.json",
"kind": "package-meta",
"package": "i18next-fs-backend",
"suspect": "created"
},
{
"path": "types/i18next-fs-backend/tslint.json",
"kind": "package-meta-ok",
"package": "i18next-fs-backend"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"lastReviewDate": "2020-08-27T09:15:19.000Z",
"reviewersWithStaleReviews": [],
"approvalFlags": 1,
"isChangesRequested": false
} |
|
🔔 @QuantumlyTangled — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to i18next-fs-backend with its source on master. Comparison details 📊
|
* feat: add typings * feat: tests
* feat: add typings * feat: tests
Please fill in this template.
npm test.)npm run lint package-name(ortscif notslint.jsonis present).Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tslint.jsonshould be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.If changing an existing definition:
tslint.jsoncontaining{ "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]and not for whole package so that the need for disabling can be reviewed.If removing a declaration:
notNeededPackages.json.