[react-native-material-menu] Repair links#47498
[react-native-material-menu] Repair links#47498sandersn merged 1 commit intoDefinitelyTyped:masterfrom
Conversation
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
@jablko Thank you for submitting this PR! This is a live comment which I will keep updated. This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you. 1 package in this PRCode ReviewsThis PR can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 47498,
"author": "jablko",
"owners": [
"KoreanThinker"
],
"dangerLevel": "ScopedAndUntested",
"headCommitAbbrOid": "a49b95a",
"headCommitOid": "a49b95a06edb28827deef793e2a6fa5b123f402f",
"mergeIsRequested": false,
"stalenessInDays": 2,
"lastPushDate": "2020-09-11T14:27:09.000Z",
"reopenedDate": "2020-09-11T19:53:10.000Z",
"lastCommentDate": "2020-09-11T14:27:09.000Z",
"maintainerBlessed": false,
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47498/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"newPackages": [],
"packages": [
"react-native-material-menu"
],
"files": [
{
"path": "types/react-native-material-menu/index.d.ts",
"kind": "definition",
"package": "react-native-material-menu"
}
],
"hasDismissedReview": false,
"ciResult": "pass",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
|
🔔 @KoreanThinker — please review this PR in the next few days. Be sure to explicitly select |
#47261