Skip to content

[react-native-material-menu] Repair links#47498

Merged
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
jablko:links/react-native-material-menu
Sep 14, 2020
Merged

[react-native-material-menu] Repair links#47498
sandersn merged 1 commit intoDefinitelyTyped:masterfrom
jablko:links/react-native-material-menu

Conversation

@jablko
Copy link
Copy Markdown
Contributor

@jablko jablko commented Sep 11, 2020

@typescript-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #47498 diff
Batch compilation
Memory usage (MiB) 89.8 90.3 +0.6%
Type count 22332 22332 0%
Assignability cache size 3982 3982 0%
Language service
Samples taken 59 59 0%
Identifiers in tests 59 59 0%
getCompletionsAtPosition
    Mean duration (ms) 351.9 337.5 -4.1%
    Mean CV 12.4% 12.3%
    Worst duration (ms) 497.2 520.2 +4.6%
    Worst identifier justifyContent flex
getQuickInfoAtPosition
    Mean duration (ms) 336.9 332.1 -1.4%
    Mean CV 11.1% 13.5% +22.1%
    Worst duration (ms) 460.4 543.4 +18.0%
    Worst identifier ref alignItems

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Sep 11, 2020
@jablko jablko marked this pull request as ready for review September 11, 2020 19:53
@typescript-bot typescript-bot added the Untested Change This PR does not touch tests label Sep 11, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Sep 11, 2020

@jablko Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Have you considered adding tests to cover the change you're making? Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ❌ Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 47498,
  "author": "jablko",
  "owners": [
    "KoreanThinker"
  ],
  "dangerLevel": "ScopedAndUntested",
  "headCommitAbbrOid": "a49b95a",
  "headCommitOid": "a49b95a06edb28827deef793e2a6fa5b123f402f",
  "mergeIsRequested": false,
  "stalenessInDays": 2,
  "lastPushDate": "2020-09-11T14:27:09.000Z",
  "reopenedDate": "2020-09-11T19:53:10.000Z",
  "lastCommentDate": "2020-09-11T14:27:09.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/47498/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Well-liked by everyone",
  "newPackages": [],
  "packages": [
    "react-native-material-menu"
  ],
  "files": [
    {
      "path": "types/react-native-material-menu/index.d.ts",
      "kind": "definition",
      "package": "react-native-material-menu"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @KoreanThinker — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@sandersn sandersn merged commit 84fa99c into DefinitelyTyped:master Sep 14, 2020
danielrearden pushed a commit to danielrearden/DefinitelyTyped that referenced this pull request Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Untested Change This PR does not touch tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants