Skip to content

update(supports-color): v7.2 and minor type change#49087

Merged
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
peterblazejewicz:update/supports-color
Oct 26, 2020
Merged

update(supports-color): v7.2 and minor type change#49087
typescript-bot merged 1 commit intoDefinitelyTyped:masterfrom
peterblazejewicz:update/supports-color

Conversation

@peterblazejewicz
Copy link
Copy Markdown
Member

  • change detail of results to be explicit false type, as there is no
    other value possible in the implementation
  • version bump
  • maintainer added

https://github.com/chalk/supports-color/blob/master/index.js#L33
chalk/supports-color@v5.3.0...v7.2.0

Thanks!

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • Include tests for your changes

- change detail of results to be explicit `false` type, as there is no
  other value possible in the implementation
- version bumpt
- maintainer added

https://github.com/chalk/supports-color/blob/master/index.js#L33
chalk/supports-color@v5.3.0...v7.2.0

Thanks!
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Oct 25, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Oct 25, 2020

@peterblazejewicz Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 49087,
  "author": "peterblazejewicz",
  "owners": [
    "mgroenhoff",
    "mtraynham"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "14324e9",
  "headCommitOid": "14324e94c71b39c418014e0e9c7b974034f573ba",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-25T16:41:59.000Z",
  "lastCommentDate": "2020-10-26T20:42:48.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/49087/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "newPackages": [],
  "packages": [
    "supports-color"
  ],
  "files": [
    {
      "path": "types/supports-color/index.d.ts",
      "kind": "definition",
      "package": "supports-color"
    },
    {
      "path": "types/supports-color/supports-color-tests.ts",
      "kind": "test",
      "package": "supports-color"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-26T04:15:36.000Z",
  "firstApprovalDate": "2020-10-26T04:15:36.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Copy Markdown
Contributor

🔔 @mgroenhoff @mtraynham — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@danger-public
Copy link
Copy Markdown

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

supports-color (unpkg)

was missing the following properties:

  1. supportsColor

Generated by 🚫 dangerJS against 14324e9

@typescript-bot
Copy link
Copy Markdown
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #49087 diff
Batch compilation
Memory usage (MiB) 39.1 39.2 +0.1%
Type count 2129 2127 0%
Assignability cache size 99 99 0%
Language service
Samples taken 16 20 +25%
Identifiers in tests 16 20 +25%
getCompletionsAtPosition
    Mean duration (ms) 95.1 94.2 -1.0%
    Mean CV 22.0% 18.6%
    Worst duration (ms) 117.4 122.7 +4.5%
    Worst identifier has16m has16m
getQuickInfoAtPosition
    Mean duration (ms) 89.4 90.4 +1.1%
    Mean CV 17.9% 15.6% -12.5%
    Worst duration (ms) 100.2 105.5 +5.3%
    Worst identifier stderr hasBasic

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Oct 25, 2020
Copy link
Copy Markdown
Contributor

@mtraynham mtraynham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Oct 26, 2020
@typescript-bot
Copy link
Copy Markdown
Contributor

@peterblazejewicz Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@mgroenhoff, @mtraynham: you can do this too.)

@peterblazejewicz
Copy link
Copy Markdown
Member Author

Ready to merge 💋

@typescript-bot typescript-bot merged commit 74867d9 into DefinitelyTyped:master Oct 26, 2020
@peterblazejewicz peterblazejewicz deleted the update/supports-color branch October 26, 2020 20:57
@typescript-bot
Copy link
Copy Markdown
Contributor

I just published @types/supports-color@7.2.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants